fix(changelog): preserve fenced code blocks in custom PR changelog entries#771
Merged
fix(changelog): preserve fenced code blocks in custom PR changelog entries#771
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
BYK
force-pushed
the
byk/fix/changelog-code-blocks
branch
from
830ecf3 to
f727b97
Compare
BYK
force-pushed
the
byk/fix/changelog-code-blocks
branch
from
f727b97 to
a200fa9
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…tries Code blocks (```lang ... ```) in custom Changelog Entry sections of PR descriptions were silently dropped during parsing. Root cause: two functions only handled a subset of marked.lexer token types: 1. extractNestedContent() only handled 'list' tokens — code blocks inside list items were skipped 2. parseTokensToEntries() only handled 'list' and 'paragraph' — standalone code blocks after paragraphs were skipped Fix: add 'code' token handling to both functions: - In extractNestedContent: render as indented fenced code block (2-space indent, matching sub-bullet level), properly handled during recursive indentation for deeper nesting - In parseTokensToEntries: attach standalone code blocks as nestedContent on the previous entry, or create a new entry if no previous one exists
BYK
force-pushed
the
byk/fix/changelog-code-blocks
branch
from
a200fa9 to
637e842
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fenced code blocks (
lang ...) in custom### Changelog EntryPR description sections were silently dropped during changelog generation.Root Cause
Two functions in
src/utils/changelog.tsonly handled a subset ofmarked.lexertoken types:extractNestedContent()— only handledlisttokens. Code blocks inside list items (the reported scenario) were silently skipped.parseTokensToEntries()— only handledlistandparagraph. Standalone code blocks after paragraphs were dropped.Fix
Added
codetoken handling to both functions:extractNestedContent(): renders code blocks as indented fenced blocks with proper nestingparseTokensToEntries(): attaches standalone code blocks asnestedContenton the previous entryChangelog Entry